Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert to using a bundle of components to install PyQt5, rather than a bundle of extensions #13336

Merged
merged 3 commits into from
Jul 3, 2021
Merged

revert to using a bundle of components to install PyQt5, rather than a bundle of extensions #13336

merged 3 commits into from
Jul 3, 2021

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jul 3, 2021 •
edited
Loading

(created using eb --new-pr)

Partially reverts the changes in #13253 for PyQt5.

Error:

== FAILED: Installation ended unsuccessfully (build directory: /tmp/eb-build/PyQt5/5.15.1/GCCcore-10.2.0): build failed (first 300 chars): cmd " /eb/software/Python/3.8.6-GCCcore-10.2.0/bin/python setup.py install --prefix=/eb/software/PyQt5/5.15.1-GCCcore-10.2.0 " exited with exit code 2 and output:
/eb/software/Python/3.8.6-GCCcore-10.2.0/bin/python: can't open file 'setup.py': [Errno 2] No such file or directory

PyQt5 install the different parts as components using a variety of EasyBlocks. Switching to exts_list stops the custom easyblock definition from being used and installs each as a PythonPackage and that causes the PyQt5 component to fail as it uses a different install method.

See easybuilders/easybuild-framework#3710 for the exts_list not honouring easyblock.

I've checked through #13253 and this is the only case I could see where this change was made.

@branfosj branfosj added this to the next release (4.4.1) milestone Jul 3, 2021
@branfosj
Copy link
Member Author

branfosj commented Jul 3, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/6f079c1c391d62cea5f537da1eea6163 for a full test report.

@branfosj branfosj changed the title Revert PyQt5 to a bundle with components Revert PyQt5 to use components Jul 3, 2021
@boegel boegel changed the title Revert PyQt5 to use components revert to using a bundle of components to install PyQt5, rather than a bundle of extensions Jul 3, 2021
@boegel
Copy link
Member

boegel commented Jul 3, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13336 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13336 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17704

Test results coming soon (I hope)...

- notification for comment with ID 873455948 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jul 3, 2021

Even with easybuilders/easybuild-framework#3762 merged (which fixes easybuilders/easybuild-framework#3710), reverting back to components is still needed for PyQt5, because the Binary easyblock can't be used to install extensions (because it doesn't derive from Extension).

boegel
boegel approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jul 3, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2669.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/660bf197f735eb7541ab04ac7560d4c8 for a full test report.

@boegel
Copy link
Member

boegel commented Jul 3, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit 81ac21b into easybuilders:develop Jul 3, 2021
@branfosj branfosj deleted the 20210703084145_new_pr_PyQt55151 branch July 3, 2021 20:14
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/922094735903b628c63dddd313c20430 for a full test report.

@Flamefire Flamefire mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@branfosj @boegel @boegelbot